Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating CICD and pkg/sdk/client files to integrate dotnet-client-sdk into dotnet-core repo #5

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

tanderson-ld
Copy link
Contributor

@tanderson-ld tanderson-ld commented Jun 7, 2024

Requirements

  • I have added test coverage for new or changed functionality

N/A

Related issues

https://app.shortcut.com/launchdarkly/story/244785/dotnet-sdk-repo-migration

Describe the solution you've provided

Pretty much the same solution as dotnet-server-sdk. Extra changes related to making it so server and client can use the same CI workflows/actions.

Base automatically changed from ta/sc-244785/copying-client-files-over to main June 7, 2024 17:58
CHANGELOG.md Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: This changelog is the dotnet-server-sdk changelog. It was moved/merged in the pkgs/sdk/server/CHANGELOG.md

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This README.md is the dotnet-server-sdk README. It was copied to pkgs/sdk/server/README.md and then this README.md was gutted/edited to fit the needs of the entire repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: No longer needed at this level, the top level .sdk_metadata.json covers this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: Top level file now covers this repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: Refreshed commands, they were very out of data on dotnet-client-sdk repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: Top level license covers the repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: Top level README.md now has nuget links

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: Covered by top level file for repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: This is the README.md that was in the dotnet-server-sdk repo, Git didn't detect the move since it was also edited to fit the needs of this repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: Original files from dotnet-client-sdk repo. I had originally not copied them over since they were no longer used by CI/CD, but there are some Makefiles that use them for quality of life for consumers, so I brought them back.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: A large number of files one moved up one level of directory to eliminate the "LaunchDarkly.ClientSdk" directory.

…d markdown URLs to point to correct locations.
@tanderson-ld tanderson-ld marked this pull request as ready for review June 7, 2024 20:23
@tanderson-ld tanderson-ld requested a review from a team June 7, 2024 20:23
public.pk Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers: This is a duplicate of pkgs/sdk/server/LaunchDarkly.pk. I guess at some point it got added to the dotnet-server-sdk repo and noone noticed it was duplicated.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@kinyoklion kinyoklion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the contributing links in readme files will need adjusted. They will link to the root by default not relative.

@tanderson-ld tanderson-ld requested a review from kinyoklion June 10, 2024 18:12
@tanderson-ld tanderson-ld merged commit fedc488 into main Jun 12, 2024
8 checks passed
@tanderson-ld tanderson-ld deleted the ta/sc-244785/migrating-dotnet-client-sdk-take2 branch June 12, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants