-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: updating CICD and pkg/sdk/client files to integrate dotnet-client-sdk into dotnet-core repo #5
chore: updating CICD and pkg/sdk/client files to integrate dotnet-client-sdk into dotnet-core repo #5
Conversation
…ent-sdk into dotnet-core repo
CHANGELOG.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: This changelog is the dotnet-server-sdk changelog. It was moved/merged in the pkgs/sdk/server/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This README.md is the dotnet-server-sdk README. It was copied to pkgs/sdk/server/README.md and then this README.md was gutted/edited to fit the needs of the entire repo.
pkgs/sdk/client/.sdk_metadata.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: No longer needed at this level, the top level .sdk_metadata.json covers this.
pkgs/sdk/client/CODEOWNERS
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: Top level file now covers this repo.
pkgs/sdk/client/CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: Refreshed commands, they were very out of data on dotnet-client-sdk repo.
pkgs/sdk/client/License.txt
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: Top level license covers the repo
pkgs/sdk/client/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: Top level README.md now has nuget links
pkgs/sdk/client/SECURITY.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: Covered by top level file for repo
pkgs/sdk/server/README.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: This is the README.md that was in the dotnet-server-sdk repo, Git didn't detect the move since it was also edited to fit the needs of this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: Original files from dotnet-client-sdk repo. I had originally not copied them over since they were no longer used by CI/CD, but there are some Makefiles that use them for quality of life for consumers, so I brought them back.
pkgs/sdk/client/src/Components.cs
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: A large number of files one moved up one level of directory to eliminate the "LaunchDarkly.ClientSdk" directory.
…d markdown URLs to point to correct locations.
public.pk
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reviewers: This is a duplicate of pkgs/sdk/server/LaunchDarkly.pk. I guess at some point it got added to the dotnet-server-sdk repo and noone noticed it was duplicated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the contributing links in readme files will need adjusted. They will link to the root by default not relative.
Co-authored-by: Ryan Lamb <[email protected]>
Requirements
N/A
I have followed the repository's pull request submission guidelines
I have validated my changes against all supported platform versions
Related issues
https://app.shortcut.com/launchdarkly/story/244785/dotnet-sdk-repo-migration
Describe the solution you've provided
Pretty much the same solution as dotnet-server-sdk. Extra changes related to making it so server and client can use the same CI workflows/actions.